Skip to content

Fix log for Grafana URL#8961

Merged
eddumelendez merged 3 commits into
testcontainers:mainfrom
rajadilipkolli:patch-1
Jul 24, 2024
Merged

Fix log for Grafana URL#8961
eddumelendez merged 3 commits into
testcontainers:mainfrom
rajadilipkolli:patch-1

Conversation

@rajadilipkolli

Copy link
Copy Markdown
Contributor

When user wants to access Grafana dashboard listening to 3000, this method helps to achieve it easily.

When user wants to access Grafana dashboard listening to 3000, this method helps to achieve it easily.
@rajadilipkolli rajadilipkolli requested a review from a team July 18, 2024 10:06
@eddumelendez

Copy link
Copy Markdown
Member

Hi @rajadilipkolli are you planning to interact to Grafana programmatically? Can you tell more about it, please? Asking because that's something I haven't had in mind.

@rajadilipkolli

Copy link
Copy Markdown
Contributor Author

Hi @eddumelendez , I want to query tempo programatically using below sample and also I want to use LGTMContainer as testcontainers in dev-mode so that I can play in UI

 given().contentType(ContentType.URLENC)
                .body("q={span.http.response.status_code=\"200\"}")
                .when()
                .post("/api/datasources/proxy/uid/tempo/api/search")
                .then()
                .statusCode(HttpStatus.SC_OK)
                .contentType(ContentType.JSON)
                .body("metrics.completedJobs", is(1))
                .body("metrics.totalJobs", is(1));

@eddumelendez

Copy link
Copy Markdown
Member

Ok, understood! and I just noticed we are logging the url but not for grafana 😢, so we should fix that. Currently, we are not exposing ports for Tempo and Loki, we can add those as well. I didn't include them at the beginning since couldn't built test for those and was looking for feedback from the community. So, your feedback is great! WDYT about fixing the log? and if you have time to add proper validation for Tempo then it would be very much appreciated

@rajadilipkolli

Copy link
Copy Markdown
Contributor Author

@eddumelendez , just fixed log before your comment. I will work on test cases over the weekend

@eddumelendez eddumelendez added this to the next milestone Jul 24, 2024
@eddumelendez eddumelendez changed the title feat : expose grafanaURL Fix log for Grafana URL Jul 24, 2024
@eddumelendez eddumelendez merged commit fa10d00 into testcontainers:main Jul 24, 2024
@eddumelendez

Copy link
Copy Markdown
Member

Thanks for your contribution, @rajadilipkolli !

@rajadilipkolli rajadilipkolli deleted the patch-1 branch July 24, 2024 01:45
@eddumelendez eddumelendez modified the milestone: next Jul 25, 2024
fokion pushed a commit to fokion/testcontainers-java that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants