Add hidden attribute to internal <Hidden /> component when the Features.Hidden feature is used#2955
Merged
RobinMalfait merged 2 commits intomainfrom Jan 31, 2024
Merged
Add hidden attribute to internal <Hidden /> component when the Features.Hidden feature is used#2955RobinMalfait merged 2 commits intomainfrom
hidden attribute to internal <Hidden /> component when the Features.Hidden feature is used#2955RobinMalfait merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
added a commit
that referenced
this pull request
Apr 15, 2024
…eatures.Hidden` feature is used (#2955) * add `hidden` attribute for `<Hidden features={Features.Hidden}>` * update changelog
This was referenced May 18, 2024
This was referenced May 21, 2024
This was referenced May 26, 2024
This was referenced May 28, 2024
This was referenced May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
hiddenattribute to the<Hidden />component if theFeatures.Hiddenis used as a feature.We used to only add
display: none, but that's not enough since certain CSS selectors still "see" this DOM node.E.g.:
space-x-4in Tailwind CSS will set themargin-lefton everything but the first DOM node. It is implemented with an exception for thehiddenattribute.Fixes: #2947