Skip to content

Make sure panels re-register when IDs are calculated in React < 18#2883

Merged
RobinMalfait merged 3 commits into1.xfrom
fix/reregister-tab-panel-id
Apr 12, 2024
Merged

Make sure panels re-register when IDs are calculated in React < 18#2883
RobinMalfait merged 3 commits into1.xfrom
fix/reregister-tab-panel-id

Conversation

@thecrypticace
Copy link
Copy Markdown
Contributor

Fixes #2882

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ❌ Failed (Inspect) Apr 12, 2024 3:16pm
headlessui-vue ❌ Failed (Inspect) Apr 12, 2024 3:16pm

@camsloanftc
Copy link
Copy Markdown

Just wanted to confirm this is an issue we are experiencing on our team and was curious if this may go in soon. Thanks!

@RobinMalfait RobinMalfait changed the base branch from main to 1.x April 12, 2024 15:09
@RobinMalfait RobinMalfait force-pushed the fix/reregister-tab-panel-id branch from 9036455 to 6c259a1 Compare April 12, 2024 15:16
@RobinMalfait RobinMalfait merged commit 2b161b3 into 1.x Apr 12, 2024
@RobinMalfait RobinMalfait deleted the fix/reregister-tab-panel-id branch April 12, 2024 15:19
ignatremizov pushed a commit to ignatremizov/headlessui that referenced this pull request Feb 21, 2026
…ailwindlabs#2883)

* Make sure panels re-register when IDs are calculated in React < 18

* Update changelog

* Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs Component Accessibility - aria-controls Value Issue in React 17

3 participants