Feat: Support module.uri in AMD extra#2485
Merged
guybedford merged 2 commits intosystemjs:mainfrom Apr 27, 2024
Merged
Conversation
File size impactMerging jackw/amd-module-uri into main will impact 4 files in 3 groups. browser (2/2)
node (1/1)
extras (1/8)
|
Member
|
Sure I would be happy to land and release this. Can you please add a test for this first? |
Contributor
Author
|
@guybedford thanks for taking a look and for the feedback. I've now added a test case for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMD modules loaded via SystemJS should have some way of knowing where they are loading from so they can load their assets. This is mentioned in the requirejs docs here. With this an amd webpack build can then use it to setup
__webpack_public_path__. e.g.Fixes: #2386
Notes for reviewers:
Should I update version and run the
buildscript in this PR to update the dist files or does that happen via github-actions after a merge to main?