fix(es/minifier): Drop unused import bindings#6967
Merged
kdy1 merged 3 commits intoswc-project:mainfrom Feb 21, 2023
Merged
Conversation
kdy1
approved these changes
Feb 20, 2023
Member
kdy1
left a comment
There was a problem hiding this comment.
Thank you!
swc-bump:
- swc_ecma_transforms_optimization
swc-bot
reviewed
Feb 21, 2023
Collaborator
swc-bot
left a comment
There was a problem hiding this comment.
Automated review comment generated by auto-rebase script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
It is always safe to remove unused import bindings and keep import statements to preserve side effects.
This transformation does not require additional options like
drop_unused_imports.BREAKING CHANGE:
Related issue (if exists):