Fix color-* performance#6868
Merged
romainmenke merged 11 commits intomainfrom May 29, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See:
color-*rulescolor-*rulesI don't mind splitting this up into multiple PR's, one for each rule, but the changes are all similar and minor.
I am unsure what the preference is in this project for balancing the extra noise and review work of multiple PR's vs. the clarity of small chunks. I didn't want to open ±10 PR's without prior discussion :)