Skip to content

Fix color-* performance#6868

Merged
romainmenke merged 11 commits intomainfrom
fix-color-rules-performance--adaptable-asian-elephant-740c875825
May 29, 2023
Merged

Fix color-* performance#6868
romainmenke merged 11 commits intomainfrom
fix-color-rules-performance--adaptable-asian-elephant-740c875825

Conversation

@romainmenke
Copy link
Copy Markdown
Member

@romainmenke romainmenke commented May 28, 2023

Which issue, if any, is this issue related to?

See:

Is there anything in the PR that needs further explanation?

  • added a fast abort for all color-* rules
  • added some utilities in support of the color-* rules
  • ensures that regexp's in utilities are declared once and then reused.

I don't mind splitting this up into multiple PR's, one for each rule, but the changes are all similar and minor.

I am unsure what the preference is in this project for balancing the extra noise and review work of multiple PR's vs. the clarity of small chunks. I didn't want to open ±10 PR's without prior discussion :)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants