feat(echo): add dynamic path support for echo endpoint#271
Merged
stefanprodan merged 2 commits intostefanprodan:masterfrom Jun 22, 2023
Merged
feat(echo): add dynamic path support for echo endpoint#271stefanprodan merged 2 commits intostefanprodan:masterfrom
stefanprodan merged 2 commits intostefanprodan:masterfrom
Conversation
merusso
reviewed
Jun 7, 2023
Comment on lines
+103
to
+104
| s.router.HandleFunc("/echo", s.echoHandler).Methods("POST,PUT") | ||
| s.router.HandleFunc("/echo/{echo:.*}", s.echoHandler).Methods("POST,PUT") |
There was a problem hiding this comment.
Suggestions:
- What about using PathPrefix() to allow "/echo/{anyPath}"?
- What about accepting all HTTP methods, e.g. not restricting these paths to specific methods?
Suggested change
| s.router.HandleFunc("/echo", s.echoHandler).Methods("POST,PUT") | |
| s.router.HandleFunc("/echo/{echo:.*}", s.echoHandler).Methods("POST,PUT") | |
| s.router.Path("/echo").HandlerFunc(s.echoHandler) | |
| s.router.PathPrefix("/echo/").HandlerFunc(s.echoHandler) |
Comment on lines
+123
to
+124
| s.router.HandleFunc("/api/echo", s.echoHandler).Methods("POST,PUT") | ||
| s.router.HandleFunc("/api/echo{echo:.*}", s.echoHandler).Methods("POST,PUT") |
There was a problem hiding this comment.
This should be consistent with the path patterns used above (currently api/echo{echo:.*} vs /echo/{echo:.*})
Contributor
Author
There was a problem hiding this comment.
This should be consistent with the path patterns used above (currently api/echo{echo:.} vs /echo/{echo:.})
This is consistent with the previous route paths; both /api/echo and /echo were exposed previously.
Contributor
Author
|
@stefanprodan bumping this PR; happy to make changes as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to add dynamic path support for both the
echoandapi/echoendpoints, so thatecho/testis also routed to the echo handler, as isecho/test/test.In addition, I've added support for PUT operations to this endpoint.