fix(sdk): lowercase hidedevtools and devtoolsheight params #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f6901a to
b447158
Compare
fvsch
commented
Nov 10, 2022
| - TypeScript: improved the precision and inline documentation of types such as `Project`, `EmbedOptions`, `OpenOptions` and `VM`. Made those types directly importable with `import type { Project } from '@stackblitz/sdk'`. (#1775, #1779, #1837) | ||
| - Added support for opening multiple files in an embedded projects with the `vm.editor.openFile` method. (#1810) | ||
| - Added new methods to the `VM` class for controlling the embedded editor’s UI: `vm.editor.setCurrentFile`, `vm.editor.setTheme`, `vm.editor.setView`, `vm.editor.showSidebar`, `vm.preview.getUrl`, `vm.preview.setUrl`. (#1810, #1837) | ||
| - Added new `showSidebar` option. (#1837) |
Contributor
Author
There was a problem hiding this comment.
Just changing the punctuation for PR references in the changelog, to make it consistent in the whole changelog.
| "bundles", | ||
| "typings" | ||
| "typings", | ||
| "CHANGELOG.md", |
Contributor
Author
There was a problem hiding this comment.
The license and readme files are included by default in npm packages, but the changelog is not. Listing all three files explicitly to make our intent clear.
| const generators: Record<keyof Options, (value: any) => string> = { | ||
| clickToLoad: (value: Options['clickToLoad']) => trueParam('ctl', value), | ||
| devToolsHeight: (value: Options['devToolsHeight']) => percentParam('devToolsHeight', value), | ||
| devToolsHeight: (value: Options['devToolsHeight']) => percentParam('devtoolsheight', value), |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (well, I) introduced a regression in version 1.7.0 of the SDK by renaming the hidedevtools and devtoolsheight URL query parameters to hideDevTools and devToolsHeight.
See: 5e89b03#diff-4db4b7030103b2f5677a33713b8c50bc15c70c96aafdf68adcd25f6f6a141a62L54-L65
While stackblitz.com does handle query parameters insensitive of case, StackBlitz EE may not (depending on the deployed version).
For backwards compatibility, those parameters should keep their original case.