Skip to content

Improve performance of canRead() in HttpMessageReader's#30192

Closed
yuzawa-san wants to merge 1 commit intospring-projects:mainfrom
yuzawa-san:decoder-mime-ordering
Closed

Improve performance of canRead() in HttpMessageReader's#30192
yuzawa-san wants to merge 1 commit intospring-projects:mainfrom
yuzawa-san:decoder-mime-ordering

Conversation

@yuzawa-san
Copy link
Copy Markdown
Contributor

@yuzawa-san yuzawa-san commented Mar 25, 2023 •
edited
Loading

  • A lot of the decoders use MimeType.ALL, so use MimeType.WILDCARD_TYPE for faster String.equals() using reference comparisons, specifically in MimeType.isWildcardType().
  • Move cheaper checks to the front of the canRead implementations. The media/mime checks appear to be cheaper than Class.isAssignableFrom which is cheaper than the ResolvableType checks, so putting them in the correct order (while preserving the and/or logic) gives an improvement.

before icicle graph for CPU from my stress test. this is for a JSON payload, thus the other readers should be skipped and take as little cpu as possible:
image

after (see how MultipartHttpMessageReader and FormHttpMessageReader have shrunk):
image

@yuzawa-san
Improve performance of HttpMessageReader.canRead()
daa6efc 
Use MimeType.WILDCARD_TYPE for faster String.equals().
Move cheaper checks to the front of the canRead implementations.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 25, 2023
rstoyanchev
rstoyanchev reviewed Mar 27, 2023
View reviewed changes
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) status: waiting-for-feedback We need additional information before we can continue labels Mar 27, 2023
@rstoyanchev rstoyanchev self-assigned this Mar 28, 2023
@rstoyanchev rstoyanchev added this to the 6.0.8 milestone Mar 28, 2023
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 28, 2023
@rstoyanchev rstoyanchev changed the title Improve performance of HttpMessageReader.canRead() Improve performance of canRead() in HttpMessageReader's Apr 11, 2023
rstoyanchev pushed a commit that referenced this pull request Apr 11, 2023
@yuzawa-san @rstoyanchev
Improve performance of canRead() in HttpMessageReader's
e77faf7 
Use MimeType.WILDCARD_TYPE for faster String.equals().
Move cheaper checks to the front of the canRead implementations.

See gh-30192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rstoyanchev rstoyanchev rstoyanchev left review comments

Assignees

@rstoyanchev rstoyanchev

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement

Projects

None yet

Milestone

6.0.8

Development

Successfully merging this pull request may close these issues.

3 participants

@yuzawa-san @rstoyanchev @spring-projects-issues