Replace Collections.unmodifiableList(new ArrayList(..)) with List.copyOf()#30166
Merged
jhoeller merged 5 commits intospring-projects:mainfrom Apr 12, 2023
Merged
Replace Collections.unmodifiableList(new ArrayList(..)) with List.copyOf()#30166jhoeller merged 5 commits intospring-projects:mainfrom
Collections.unmodifiableList(new ArrayList(..)) with List.copyOf()#30166jhoeller merged 5 commits intospring-projects:mainfrom
Conversation
|
@ssang1105 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ssang1105 Thank you for signing the Contributor License Agreement! |
Collections.unmodifiableList(new ArrayList(..)) with List.copyOf()
rstoyanchev
reviewed
Mar 27, 2023
Contributor
rstoyanchev
left a comment
There was a problem hiding this comment.
There is one more such case in DefaultMetadataExtractor.
Contributor
Author
|
@rstoyanchev I found and fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
Collections.unmodifiableList()withList.copyOf().It creates a new immutable list by copying the elements of the given list.
Using
List.copyOf()results in more readable and prevents unexpected bugs, and makes the code easier to maintain.