Use String.equals() in LiteralPathElement#30138
Closed
yuzawa-san wants to merge 1 commit intospring-projects:mainfrom
Closed
Use String.equals() in LiteralPathElement#30138yuzawa-san wants to merge 1 commit intospring-projects:mainfrom
yuzawa-san wants to merge 1 commit intospring-projects:mainfrom
Conversation
5388fc8 to
d50525d
Compare
Contributor
|
I changed the PR to remove the I then ran our JMH |
poutsma
added a commit
that referenced
this pull request
Mar 22, 2023
…quals * gh-30138: Polish external contribution Use String.equals() in LiteralPathElement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.equals() eventually calls StringLatin1.equals() which uses processor-specific intrinsics. They are available for major architectures and typically use some sort of processor-optimized vector operations, which should be faster than the current for-loop.
Before:
After:
