Simplify getCache() method in CaffeineCacheManager#24376
Closed
bananayong wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Kwangyong Kim <banana.yong@gmail.com>
|
@bananayong Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@bananayong Thank you for signing the Contributor License Agreement! |
Member
|
Thanks for the PR! I ended up implementing this slightly differently in 16e49bf. |
Contributor
Author
|
Thank you to reflect my contribution. But, I would like to give an opinion. cacheName -> this.dynamic ? createCaffeineCache(cacheName) : nullThis lambda expression accesses Please, ignore this comment if there is no big benefits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to make some contributions.
Current spring framework is based on JDK8. So, CaffeineCacheManager.getCache() method can be simplified with Map.computeIfAbsent
Thank you.