Add BeanPropertyRowMapper.newInstance(mappedClass, conversionService)#24195
Merged
Conversation
Similar to SingleColumnRowMapper.newInstance(requiredType, conversionService) which was added in #1678.
|
@perceptron8 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@perceptron8 Thank you for signing the Contributor License Agreement! |
Contributor
|
Good point, it makes sense to add such an overloaded factory method there as well. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider adding
BeanPropertyRowMapper.newInstance(mappedClass, conversionService).I believe it's going to cover most use cases requiring custom conversion service.
This is similar to
SingleColumnRowMapper.newInstance(requiredType, conversionService)which was added in #1678.You may like / need to add
@sincein javadoc. I wasn't sure what version to use.