Regression: prototype @ControllerAdvice beans should not be cached#24157
Closed
yokotaso wants to merge 1 commit into
Closed
Regression: prototype @ControllerAdvice beans should not be cached#24157yokotaso wants to merge 1 commit into
yokotaso wants to merge 1 commit into
Conversation
Member
|
Good catch! Thanks for submitting the PR. |
sbrannen
added a commit
that referenced
this pull request
Dec 7, 2019
Member
sbrannen
added a commit
that referenced
this pull request
Dec 7, 2019
sbrannen
added a commit
that referenced
this pull request
Dec 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is ignored that the scope of bean, which is annotated
@ControllerAdvice.Broken at this commit.
21267e5
Bean of ControllerAdvice is wrongly cached, I think.
If Scope of Bean which is annotated
@ControllerAdviceandregister as a not singleton component,
ControllerAdviceBean#resolveBean()shouldrequest to BeanFactory.