Add protobuf MessageConverter#24087
Conversation
d711343 to
c698376
Compare
|
if we want eliminate anything related to protobuf-java-forma and support official |
There was a problem hiding this comment.
Correct the braces throughout, please :)
There was a problem hiding this comment.
Sorry. it is my first contribution to spring. thanks for correcting me
|
Indeed we could simplify a bit by removing |
|
I’m doing new commits so that you can see what I fixed, at the end I’ll collect in one commit. |
|
This looks much better. Feel free to squash the commits, I'm only looking for the end result. In terms of your other question about where to add the converter to, I'd say in |
6a1b36f to
7a16cff
Compare
|
@parviz-93 thanks so much for your contribution and following through with the changes! This is now merged in. I ended up making a few further changes, adding a sub-class of the protobuf converter (just like in spring-web) because if it all came in one converter, the JSON format support wouldn't be optional. As a consequence I also decided to pull out the automatic registration in Java and XML config. |
|
Thank you very much for your help and advice. |
|
This was quick. Thanks a lot |
PR for #24022.
Should I add this converter to ...?
SimpAnnotationMethodMessageHandlerAbstractMessageBrokerConfigurationMessageBrokerBeanDefinitionParserI found that other converters are used in these classes.