Skip to content

Simplify ConstructorResolver: do not sort intermediate array#23969

Merged
jhoeller merged 1 commit into
spring-projects:masterfrom
stsypanov:simplify-const-resolver
Nov 11, 2019
Merged

Simplify ConstructorResolver: do not sort intermediate array#23969
jhoeller merged 1 commit into
spring-projects:masterfrom
stsypanov:simplify-const-resolver

Conversation

@stsypanov

Copy link
Copy Markdown
Contributor

There's no need to create an intermediate array of Method candidates just to sort it. Intead we can directly sort existing ArrayList which costs us the same as there's array under the hood.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 11, 2019
@jhoeller jhoeller self-assigned this Nov 11, 2019
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 11, 2019
@jhoeller jhoeller added this to the 5.2.2 milestone Nov 11, 2019
@jhoeller jhoeller merged commit 92efe95 into spring-projects:master Nov 11, 2019
@stsypanov stsypanov deleted the simplify-const-resolver branch November 11, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants