Fix for redundant assertion in ValueRangeAnalysisFactory#2887
Merged
Conversation
hazendaz
approved these changes
Mar 4, 2024
PatrikScully
pushed a commit
to PatrikScully/spotbugs
that referenced
this pull request
Jun 14, 2024
* test: reproducer for crash in redundant condition assertion Crash reported in issue spotbugs#608 * fix: calculate the end position of the assert block by finding ATHROW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a redundant condition is used in an assertion ValueRangeAnalysisFactory tries to compute the position of the end end for the corresponding instruction block. However it uses
IFNE.getTarget().getPosition()which returns the position offset (not he position).Since the offset is zero, this produces and invalid range (end is before start) and
BitSet.set(start, end)throws an exception.Instead compute the end of the block by locating the final
athrowCrash reported in issue #608