Skip to content

feat: Add TS 5.0 options#573

Merged
sindresorhus merged 5 commits intosindresorhus:mainfrom
shun-shobon:feature/add-ts-5.0-options
Mar 17, 2023
Merged

feat: Add TS 5.0 options#573
sindresorhus merged 5 commits intosindresorhus:mainfrom
shun-shobon:feature/add-ts-5.0-options

Conversation

@shun-shobon
Copy link
Copy Markdown
Contributor

@shun-shobon shun-shobon commented Mar 16, 2023

Hi. I have added an option to tsconfig.json that was added by the recently released TypeScript 5.0.

Ref: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0

sindresorhus
sindresorhus reviewed Mar 16, 2023
View reviewed changes
Comment thread source/tsconfig-json.d.ts Outdated
@sindresorhus
Copy link
Copy Markdown
Owner

sindresorhus commented Mar 16, 2023

Thanks for working on this. Can you double check that you covered all the changes for 5.0?

@shun-shobon @sindresorhus
style: Remove space
6e29150 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@shun-shobon
Copy link
Copy Markdown
Contributor Author

shun-shobon commented Mar 16, 2023

I forgot to check this section here. I will fix it.
https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#deprecations-and-default-changes

@shun-shobon
Copy link
Copy Markdown
Contributor Author

shun-shobon commented Mar 16, 2023

@sindresorhus
I checked it. Can you review this?

@shun-shobon shun-shobon mentioned this pull request Mar 16, 2023
Merged
@kidonng
Copy link
Copy Markdown
Contributor

kidonng commented Mar 17, 2023 •
edited
Loading

According to https://github.com/SchemaStore/schemastore/pull/2754/files#diff-c2958f962599020051d4dcbd1983284db50f59857bf58b26b24da6d6a763a257R572, the Target type should add ES2023.

@shun-shobon
Copy link
Copy Markdown
Contributor Author

shun-shobon commented Mar 17, 2023

@kidonng

I have tested and it appears that TS5.0.2 does not support ES2023.

image

@kidonng
Copy link
Copy Markdown
Contributor

kidonng commented Mar 17, 2023

That's weird, because there are definitions for ES2023: https://github.com/microsoft/TypeScript/blob/v5.0.2/lib/lib.es2023.d.ts
Some TS internals might be outdated I guess.

@shun-shobon
Copy link
Copy Markdown
Contributor Author

shun-shobon commented Mar 17, 2023 •
edited
Loading

When I was running TypeScript, it seems that Node10 was added to the moduleResolution. There's a lot I don't understand since the documentation hasn't been updated yet...

microsoft/TypeScript#51901

@sindresorhus sindresorhus merged commit aafc938 into sindresorhus:main Mar 17, 2023
@shun-shobon shun-shobon deleted the feature/add-ts-5.0-options branch March 17, 2023 08:10
@michalbundyra michalbundyra mentioned this pull request Mar 20, 2023
Merged
3 tasks
@michalbundyra
Copy link
Copy Markdown

michalbundyra commented Mar 21, 2023

@sindresorhus As it is merged, can we expect a release soon? Or something else needs to be done to provide support for TypeScript 5.0? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shun-shobon @sindresorhus @kidonng @michalbundyra