Skip to content

Create release draft even when pushing to protected branches failed#560

Merged
sindresorhus merged 5 commits intosindresorhus:masterfrom
bunysae:branch_protection
Aug 29, 2020
Merged

Create release draft even when pushing to protected branches failed#560
sindresorhus merged 5 commits intosindresorhus:masterfrom
bunysae:branch_protection

Conversation

@bunysae
Copy link
Copy Markdown
Contributor

@bunysae bunysae commented Aug 17, 2020

Fixes #502.

Setup for tests:

  1. setup branch protection fro some playground repository
  2. publish new version with np

The tags should be pushed and the release draft should be created.

Comment thread source/git-util.js Outdated
Comment thread source/git-util.js Outdated
@sindresorhus
Copy link
Copy Markdown
Owner

Ideally, we should inform the user that they need to manually push the commits.

@bunysae bunysae force-pushed the branch_protection branch from 6b676e4 to d32d122 Compare August 26, 2020 14:41
@sindresorhus sindresorhus changed the title Creating release draft when pushing to protected branches failed Create release draft even when pushing to protected branches failed Aug 29, 2020
@sindresorhus sindresorhus merged commit 3fc1e77 into sindresorhus:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create release notes even if pushing the branch failed

2 participants