Update .ko.yaml#3240
Merged
trevrosen merged 1 commit intosigstore:mainfrom Sep 15, 2023
Merged
Conversation
Use newer debian12 images explicitly Signed-off-by: Appu <appu@google.com>
Member
Author
|
cc: @jku |
Codecov Report
@@ Coverage Diff @@
## main #3240 +/- ##
=======================================
Coverage 30.37% 30.37%
=======================================
Files 155 155
Lines 9835 9835
=======================================
Hits 2987 2987
Misses 6402 6402
Partials 446 446 |
Contributor
|
@cpanato Do you know if we need a shell? the debug option for distroless adds that, I'm thinking we can remove that for the base images |
Member
we dont, only if the user need to have a long running thing to run several commands |
trevrosen
approved these changes
Sep 15, 2023
Member
Author
|
uh so should this not use |
Contributor
|
Let's open another PR. Since we aren't using libc or libssl, do we want to just switch to static? |
lance
pushed a commit
to securesign/cosign
that referenced
this pull request
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use newer debian12 images explicitly