fix: update error in SignedEntity to be more descriptive#3233
Merged
znewman01 merged 4 commits intosigstore:mainfrom Sep 10, 2023
Merged
fix: update error in SignedEntity to be more descriptive#3233znewman01 merged 4 commits intosigstore:mainfrom
SignedEntity to be more descriptive#3233znewman01 merged 4 commits intosigstore:mainfrom
Conversation
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3233 +/- ##
==========================================
- Coverage 30.37% 30.35% -0.02%
==========================================
Files 155 155
Lines 9828 9834 +6
==========================================
Hits 2985 2985
- Misses 6397 6403 +6
Partials 446 446
|
znewman01
suggested changes
Sep 10, 2023
Contributor
znewman01
left a comment
There was a problem hiding this comment.
Thanks for this change! Overall looks good, I have a couple of Go-specific requests.
Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
znewman01
approved these changes
Sep 10, 2023
lance
pushed a commit
to securesign/cosign
that referenced
this pull request
Sep 25, 2023
…3233) * fix: add func to generate `entity not found` error Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> * fix: update format specifier in fmt.Errorf Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> * feat: make ErrEntityNotFound error message less common Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> * feat: make EntityNotFoundError a first-class error Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com> --------- Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2930
The exact error described in the issue cannot happen anymore as that behavior was changed in v2.1.0.
PR #2959 updated the old behaviour and added an if case where the error message is used in an if statement. The issue with this is that the error value is lost when
ErrEntityNotFounderror is created. This creates a problem where the error inSignedEntityare not descriptive enough whenremoteGetfunction fails.This PR will:
NewEntityNotFoundErrorwhich uses the error received byremoteGetto create a new error.IsEntityNotFoundErrorwhich is used in the if statement that checks if the error message contains anErrEntityNotFoundstring.Release Note
Updated error in
SignedEntityto be more descriptivecc @znewman01