url: add the authority method by unleashed · Pull Request #674 · servo/rust-url

unleashed · 2021-02-08T15:26:57Z

This is a revisit of #15 to add a method to be able to get the authority on its own.

Much has changed in the meantime, and the method can now be implemented without needing an additional struct.

djc

Thanks for working on this, I think it makes sense to add this. Before we merge it, I'd look to see a little more test coverage to ensure the current documentation matches the implementation.

djc · 2021-02-08T20:20:39Z

+    /// Non-ASCII domains are punycode-encoded per IDNA if this is the host
+    /// of a special URL, or percent encoded for non-special URLs.
+    /// IPv6 addresses are given between `[` and `]` brackets.


Are you sure that this documentation is actually how it works? Would be good to add a unit test that covers some of these cases, with at least one IDNA-encoded domain, one percent-encoded host and an IPv6 host.

Thanks for thr review, @djc.

Yes, I am sure - the documentation is taken from methods that already state this and are implemented in a similar fashion by taking an internal slice. I've added another commit with a few more doc tests to exercise what is being said here and also added a note on ports for special URLs, which are omitted from the authority if they match the well known scheme port.

Thanks for adding the tests!

I'd prefer to have this as unit tests not doctests, otherwise the example code gets a bit too bulky for my taste.

Agreed, it's a bit too much for docs. Moved those to unit tests leaving just a few examples and also took the opportunity to add unit tests for has_authority.

bors-servo · 2021-05-03T09:11:27Z

☔ The latest upstream changes (presumably #703) made this pull request unmergeable. Please resolve the merge conflicts.

unleashed · 2021-05-15T17:35:39Z

Rebased to fix conflicts.

SimonAdameit · 2021-09-22T18:14:15Z

Hi, I'd be interested in having this. What's still required to get it merged?

unleashed · 2021-09-24T06:06:26Z

I don't know of any specific roadblock other than having a maintainer review and approve it.

pehala · 2022-10-25T10:52:20Z

I would like to revive this PR, is there anything required other than rebasing to the current main?

valenting · 2022-10-25T10:59:36Z

Rebase on the latest changes for the CI to run.
Then we can probably merge this.

Signed-off-by: Alejandro Martinez Ruiz <alex@flawedcode.org>

unleashed · 2022-10-25T11:22:50Z

@pehala @valenting rebased on top of latest master.

valenting

Thanks!

151: fix(deps): update rust crate camino to 1.1.6 r=renovate[bot] a=renovate[bot] [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [camino](https://togithub.com/camino-rs/camino) | dependencies | minor | `1.0.9` -> `1.1.6` | --- ### Release Notes <details> <summary>camino-rs/camino (camino)</summary> ### [`v1.1.6`](https://togithub.com/camino-rs/camino/blob/HEAD/CHANGELOG.md#116---2023-07-11) [Compare Source](https://togithub.com/camino-rs/camino/compare/camino-1.1.4...camino-1.1.6) ##### Added - Implement `Deserialize` for `Box<Utf8Path>`. ### [`v1.1.4`](https://togithub.com/camino-rs/camino/blob/HEAD/CHANGELOG.md#114---2023-03-09) [Compare Source](https://togithub.com/camino-rs/camino/compare/camino-1.1.3...camino-1.1.4) ##### Added - Implement `DerefMut` for `Utf8PathBuf` on Rust 1.68 and above. ### [`v1.1.3`](https://togithub.com/camino-rs/camino/blob/HEAD/CHANGELOG.md#113---2023-02-21) [Compare Source](https://togithub.com/camino-rs/camino/compare/camino-1.1.2...camino-1.1.3) ##### Added - New method `Utf8DirEntry::into_path` to return an owned `Utf8PathBuf`. ### [`v1.1.2`](https://togithub.com/camino-rs/camino/blob/HEAD/CHANGELOG.md#112---2022-08-12) [Compare Source](https://togithub.com/camino-rs/camino/compare/camino-1.1.1...camino-1.1.2) ##### Added - New convenience methods \[`FromPathBufError::into_io_error`] and \[`FromPathError::into_io_error`]. ### [`v1.1.1`](https://togithub.com/camino-rs/camino/blob/HEAD/CHANGELOG.md#111---2022-08-12) [Compare Source](https://togithub.com/camino-rs/camino/compare/camino-1.1.0...camino-1.1.1) ##### Fixed - Fixed a build regression on older nightlies in the 1.63 series ([#22](https://togithub.com/camino-rs/camino/issues/22)). - Documentation fixes. ### [`v1.1.0`](https://togithub.com/camino-rs/camino/blob/HEAD/CHANGELOG.md#110---2022-08-11) [Compare Source](https://togithub.com/camino-rs/camino/compare/camino-1.0.9...camino-1.1.0) ##### Added - New methods, mirroring those in recent versions of Rust: - `Utf8Path::try_exists` checks whether a path exists. Note that while `std::path::Path` only provides this method for Rust 1.58 and above, `camino` backfills the method for all Rust versions it supports. - `Utf8PathBuf::shrink_to` shrinks a `Utf8PathBuf` to a given size. This was added in, and is gated on, Rust 1.56+. - `Utf8PathBuf::try_reserve` and `Utf8PathBuf::try_reserve_exact` implement fallible allocations. These were added in, and are gated on, Rust 1.63+. - A number of `#[must_use]` annotations to APIs, mirroring those added to `Path` and `PathBuf` in recent versions of Rust. The minor version bump is due to this change. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jaysonsantos/aur-pkgbuild-updater).  153: fix(deps): update rust crate url to 2.4.1 r=renovate[bot] a=renovate[bot] [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [url](https://togithub.com/servo/rust-url) | dependencies | minor | `2.2.2` -> `2.4.1` | --- ### Release Notes <details> <summary>servo/rust-url (url)</summary> ### [`v2.4.1`](https://togithub.com/servo/rust-url/releases/tag/v2.4.1) [Compare Source](https://togithub.com/servo/rust-url/compare/v2.4.0...v2.4.1) #### What's Changed - Move debugger_visualizer tests to separate crate by [`@lucacasonato](https://togithub.com/lucacasonato)` in [https://github.com/servo/rust-url/pull/853](https://togithub.com/servo/rust-url/pull/853) - Remove obsolete badge references by [`@atouchet](https://togithub.com/atouchet)` in [https://github.com/servo/rust-url/pull/852](https://togithub.com/servo/rust-url/pull/852) - Fix trailing spaces in scheme / pathname / search setters by [`@lucacasonato](https://togithub.com/lucacasonato)` in [https://github.com/servo/rust-url/pull/848](https://togithub.com/servo/rust-url/pull/848) - fix: implement std::error::Error for data-url by [`@lucacasonato](https://togithub.com/lucacasonato)` in [https://github.com/servo/rust-url/pull/698](https://togithub.com/servo/rust-url/pull/698) - Enable the GitHub merge queue by [`@mrobinson](https://togithub.com/mrobinson)` in [https://github.com/servo/rust-url/pull/851](https://togithub.com/servo/rust-url/pull/851) - Rewrite WPT runner by [`@lucacasonato](https://togithub.com/lucacasonato)` in [https://github.com/servo/rust-url/pull/857](https://togithub.com/servo/rust-url/pull/857) - Implement std::error::Error for InvalidBase64 by [`@lucacasonato](https://togithub.com/lucacasonato)` in [https://github.com/servo/rust-url/pull/856](https://togithub.com/servo/rust-url/pull/856) - Add `--generate-link-to-definition` option when building on docs.rs by [`@GuillaumeGomez](https://togithub.com/GuillaumeGomez)` in [https://github.com/servo/rust-url/pull/858](https://togithub.com/servo/rust-url/pull/858) - Stabilize debugger_visualizer feature by [`@lucacasonato](https://togithub.com/lucacasonato)` in [https://github.com/servo/rust-url/pull/855](https://togithub.com/servo/rust-url/pull/855) - Update WPT data and expectations by [`@lucacasonato](https://togithub.com/lucacasonato)` in [https://github.com/servo/rust-url/pull/859](https://togithub.com/servo/rust-url/pull/859) - Fix no_std Support for idna by [`@domenukk](https://togithub.com/domenukk)` in [https://github.com/servo/rust-url/pull/843](https://togithub.com/servo/rust-url/pull/843) - Fix panic in set_path for file URLs by [`@valenting](https://togithub.com/valenting)` in [https://github.com/servo/rust-url/pull/865](https://togithub.com/servo/rust-url/pull/865) #### New Contributors - [`@mrobinson](https://togithub.com/mrobinson)` made their first contribution in [https://github.com/servo/rust-url/pull/851](https://togithub.com/servo/rust-url/pull/851) - [`@GuillaumeGomez](https://togithub.com/GuillaumeGomez)` made their first contribution in [https://github.com/servo/rust-url/pull/858](https://togithub.com/servo/rust-url/pull/858) - [`@domenukk](https://togithub.com/domenukk)` made their first contribution in [https://github.com/servo/rust-url/pull/843](https://togithub.com/servo/rust-url/pull/843) **Full Changelog**: servo/rust-url@v2.4.0...v2.4.1 ### [`v2.4.0`](https://togithub.com/servo/rust-url/releases/tag/v2.4.0) [Compare Source](https://togithub.com/servo/rust-url/compare/v2.3.1...v2.4.0) #### Crate version bump - data-url to 0.3.0 - percent-encoding to 2.3.0 - form_urlencoded to 1.2.0 - idna to 0.4.0 - url to 2.4.0 #### What's Changed - url: add the authority method by [`@unleashed](https://togithub.com/unleashed)` in [https://github.com/servo/rust-url/pull/674](https://togithub.com/servo/rust-url/pull/674) - Fix clippy warnings by [`@nickelc](https://togithub.com/nickelc)` in [https://github.com/servo/rust-url/pull/810](https://togithub.com/servo/rust-url/pull/810) - Replace unmaintained/outdated github actions by [`@nickelc](https://togithub.com/nickelc)` in [https://github.com/servo/rust-url/pull/811](https://togithub.com/servo/rust-url/pull/811) - Implement potentially strip spaces for opaque paths by [`@CYBAI](https://togithub.com/CYBAI)` in [https://github.com/servo/rust-url/pull/813](https://togithub.com/servo/rust-url/pull/813) - percent_encoding: faster percent_encode_byte by [`@klensy](https://togithub.com/klensy)` in [https://github.com/servo/rust-url/pull/814](https://togithub.com/servo/rust-url/pull/814) - Update urltestdata.json WPT test cases by [`@valenting](https://togithub.com/valenting)` in [https://github.com/servo/rust-url/pull/819](https://togithub.com/servo/rust-url/pull/819) - Fix anarchist URL where path starts with // by [`@qsantos](https://togithub.com/qsantos)` in [https://github.com/servo/rust-url/pull/817](https://togithub.com/servo/rust-url/pull/817) - Avoid string allocation to get length of port by [`@qsantos](https://togithub.com/qsantos)` in [https://github.com/servo/rust-url/pull/823](https://togithub.com/servo/rust-url/pull/823) - No colon when setting empty password by [`@qsantos](https://togithub.com/qsantos)` in [https://github.com/servo/rust-url/pull/825](https://togithub.com/servo/rust-url/pull/825) - Url is special by [`@qsantos](https://togithub.com/qsantos)` in [https://github.com/servo/rust-url/pull/826](https://togithub.com/servo/rust-url/pull/826) - Update msrv to 1.56 to keep up with serde-derive by [`@valenting](https://togithub.com/valenting)` in [https://github.com/servo/rust-url/pull/827](https://togithub.com/servo/rust-url/pull/827) - `no_std` support for `form_urlencoded`, `data-url` and `idna` by [`@madsmtm](https://togithub.com/madsmtm)` in [https://github.com/servo/rust-url/pull/722](https://togithub.com/servo/rust-url/pull/722) - Compile with serde feature on Rust playground and docs.rs by [`@dtolnay](https://togithub.com/dtolnay)` in [https://github.com/servo/rust-url/pull/832](https://togithub.com/servo/rust-url/pull/832) - Fix issues with file drives by [`@valenting](https://togithub.com/valenting)` in [https://github.com/servo/rust-url/pull/839](https://togithub.com/servo/rust-url/pull/839) - Update url to 2.4.0 and release new version by [`@valenting](https://togithub.com/valenting)` in [https://github.com/servo/rust-url/pull/840](https://togithub.com/servo/rust-url/pull/840) #### New Contributors - [`@nickelc](https://togithub.com/nickelc)` made their first contribution in [https://github.com/servo/rust-url/pull/810](https://togithub.com/servo/rust-url/pull/810) - [`@CYBAI](https://togithub.com/CYBAI)` made their first contribution in [https://github.com/servo/rust-url/pull/813](https://togithub.com/servo/rust-url/pull/813) - [`@klensy](https://togithub.com/klensy)` made their first contribution in [https://github.com/servo/rust-url/pull/814](https://togithub.com/servo/rust-url/pull/814) - [`@qsantos](https://togithub.com/qsantos)` made their first contribution in [https://github.com/servo/rust-url/pull/817](https://togithub.com/servo/rust-url/pull/817) - [`@madsmtm](https://togithub.com/madsmtm)` made their first contribution in [https://github.com/servo/rust-url/pull/722](https://togithub.com/servo/rust-url/pull/722) - [`@dtolnay](https://togithub.com/dtolnay)` made their first contribution in [https://github.com/servo/rust-url/pull/832](https://togithub.com/servo/rust-url/pull/832) **Full Changelog**: servo/rust-url@v2.3.1...v2.4.0 ### [`v2.3.1`](https://togithub.com/servo/rust-url/compare/v2.3.0...v2.3.1) [Compare Source](https://togithub.com/servo/rust-url/compare/v2.3.0...v2.3.1) ### [`v2.3.0`](https://togithub.com/servo/rust-url/compare/v2.2.2...v2.3.0) [Compare Source](https://togithub.com/servo/rust-url/compare/v2.2.2...v2.3.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jaysonsantos/aur-pkgbuild-updater).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

url: add the authority method

djc reviewed Feb 8, 2021

View reviewed changes

unleashed force-pushed the add-authority-fn branch 2 times, most recently from 3a31b7e to 104d85c Compare February 9, 2021 14:34

djc approved these changes Feb 9, 2021

View reviewed changes

unleashed force-pushed the add-authority-fn branch from 104d85c to b2d85e1 Compare May 15, 2021 17:31

unleashed added 2 commits October 25, 2022 13:21

url: add the authority method

8b3ee5a

Signed-off-by: Alejandro Martinez Ruiz <alex@flawedcode.org>

url/tests/unit: add tests for the has_authority and authority methods

d8d4753

Signed-off-by: Alejandro Martinez Ruiz <alex@flawedcode.org>

unleashed force-pushed the add-authority-fn branch from b2d85e1 to d8d4753 Compare October 25, 2022 11:21

valenting approved these changes Oct 26, 2022

View reviewed changes

valenting merged commit 1c1e406 into servo:master Oct 26, 2022

pehala mentioned this pull request Oct 31, 2022

Migrate from using 3scale rust-url fork 3scale/threescale-wasm-auth#96

Merged

pehala mentioned this pull request Mar 14, 2023

Migrate from using our own fork of rust-url 3scale/threescale-wasm-auth#105

Open

pehala mentioned this pull request Jun 12, 2023

Migrate from using rust-url fork 3scale-rs/straitjacket#30

Merged

renovate Bot mentioned this pull request Jun 25, 2023

chore(deps): update rust docker tag to v1.77 timvw/qv#69

Merged

1 task

renovate Bot mentioned this pull request Aug 24, 2023

fix(deps): update all non-major dependencies jaysonsantos/mambembe#55

Merged

1 task

takumi-earth pushed a commit to earthlings-dev/rust-url that referenced this pull request Jan 27, 2026

Merge pull request servo#674 from 3scale-rs/add-authority-fn

2368650

url: add the authority method

Uh oh!

Conversation

unleashed commented Feb 8, 2021

Uh oh!

djc left a comment

Choose a reason for hiding this comment

Uh oh!

djc Feb 8, 2021

Choose a reason for hiding this comment

Uh oh!

unleashed Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

djc Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

unleashed Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

djc Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

bors-servo commented May 3, 2021

Uh oh!

unleashed commented May 15, 2021

Uh oh!

SimonAdameit commented Sep 22, 2021

Uh oh!

unleashed commented Sep 24, 2021

Uh oh!

pehala commented Oct 25, 2022

Uh oh!

valenting commented Oct 25, 2022

Uh oh!

unleashed commented Oct 25, 2022

Uh oh!

valenting left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants