Fix (de)serialization of new types where the internal type is skipped#1622
Merged
dtolnay merged 2 commits intoserde-rs:masterfrom Sep 8, 2019
Xaeroxe:fix-new-types
Merged
Fix (de)serialization of new types where the internal type is skipped#1622dtolnay merged 2 commits intoserde-rs:masterfrom Xaeroxe:fix-new-types
dtolnay merged 2 commits intoserde-rs:masterfrom
Xaeroxe:fix-new-types
Conversation
Contributor
Author
|
This isn't quite ready for merge yet. The bug fix still needs to be applied to the functions for other forms of tagging in enums. I'll work on that in the morning. |
Contributor
Author
|
Ok, this has been applied to other enum representations and is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1396
The derive logic for newtype variants was not considering the possibility that the one value in the newtype might be skipped. This pull request fixes that. Additionally it adds some test cases that failed before, and now succeed.