Don't generate code with redundant closures#1492
Merged
dtolnay merged 1 commit intoserde-rs:masterfrom Mar 1, 2019
Merged
Conversation
dtolnay
reviewed
Mar 1, 2019
Member
dtolnay
left a comment
There was a problem hiding this comment.
Thanks. Please remove the second commit. I would like for unrelated PRs not to fail in CI whenever Clippy adds new lints.
Contributor
Author
|
Okay. I guess there is no other way we can prevent regressions? |
ec4df88 to
2ea43c8
Compare
Contributor
Author
|
@dtolnay 2nd commit removed :) |
Member
|
This should help catch regressions: https://github.com/serde-rs/clippy-ci |
Member
|
Thanks again. Released in 1.0.89. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #1491.
I also changed the .travis.yml file to properly install clippy and removed the job from the "allow_failure_ matrix. Further explanations in #1491.
If that is not welcomed, I am happy to remove the last commit again but then I am not sure how to actually test the code change to prevent regressions.