Allow #[serde(tag="...")] on structs#1448
Merged
dtolnay merged 4 commits intoserde-rs:masterfrom Dec 28, 2018
Merged
Conversation
Added test test_internally_tagged_struct Renamed EnumTag to TagType as it now also used for structs Modified serialize_struct_as_struct
dtolnay
reviewed
Dec 27, 2018
Member
dtolnay
left a comment
There was a problem hiding this comment.
Nice. Please limit this to structs with named fields and add a ui test checking the error message when a tag attribute is given on a tuple struct or unit struct.
Added ui test struct-representation/internally-tagged-unit
Added ui test struct-representation/internally-tagged-tuple
Limited the serde(tag = "...") to enums and structs with named field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch to address #760 to allow #[serde(tag="...")] on structs. I guess, this patch would require a change in the docs, so it is still WIP.
Added test test_internally_tagged_struct.
Renamed EnumTag to TagType as it now also used for structs.
Modified serialize_struct_as_struct.
Removed ui/enum-representation/internally-tagged-struct test