Fix internally tagged enum deserialization with unknown fields#1376
Merged
dtolnay merged 2 commits intoserde-rs:masterfrom Sep 7, 2018
dreid:fix-internally-tagged-enum-deserialization-with-unknown-fields
Merged
Fix internally tagged enum deserialization with unknown fields#1376dtolnay merged 2 commits intoserde-rs:masterfrom dreid:fix-internally-tagged-enum-deserialization-with-unknown-fields
dtolnay merged 2 commits intoserde-rs:masterfrom
dreid:fix-internally-tagged-enum-deserialization-with-unknown-fields
Conversation
Member
|
I released this fix in 1.0.77. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently an internally tagged enum with a unit variant will fail to deserialize if the map contains unknown fields.
Example on Playground
This change attempts to address that by having the
InternallyTaggedUnitVisitor.visit_mapmethod consume the map before returning.I've added a test case for the simple enum case and for the case where the unit enum variant is flattened into a struct.