Fix compilation under rc feature#1359
Merged
dtolnay merged 1 commit intoserde-rs:masterfrom Aug 21, 2018
Pratyush:master
Merged
Fix compilation under rc feature#1359dtolnay merged 1 commit intoserde-rs:masterfrom Pratyush:master
rc feature#1359dtolnay merged 1 commit intoserde-rs:masterfrom
Pratyush:master
Conversation
Member
|
I published 1.0.72 with this fix. |
Contributor
Author
|
Great, thanks! I was wondering why this slipped past CI, and it seems like travis.sh doesn't check "alloc + rc" anywhere. To fix this, would I just add a line to that effect here: Line 52 in befc7ed |
Member
|
Yes that would be a good idea. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently compilation fails when enabling both the
allocandrcfeatures because of an update toliballoc. A previous PR (#1335) to fix this didn't catch thatArcnow lives underalloc::sync. This is a quick fix =)