Skip to content

Fix: options.uri must be string #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
childish-sambino merged 1 commit into from
Mar 30, 2020
Merged

Fix: options.uri must be string #985

childish-sambino merged 1 commit into from
Mar 30, 2020

Conversation

@shrujalshah28
Copy link
Contributor

@shrujalshah28 shrujalshah28 commented Sep 17, 2019

Fixes

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Short description of what this PR does:

  • Fix issue with request package, it is looking for URI or URL when baseUrl is set,

If you have questions, please send an email to Twilio SendGrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 17, 2019
@childish-sambino childish-sambino force-pushed the master branch 5 times, most recently from 389fa8c to 37473ad Compare January 15, 2020 21:44
childish-sambino
childish-sambino approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino merged commit 5dc1429 into sendgrid:master Mar 30, 2020
@shrujalshah28 shrujalshah28 deleted the patch-1 branch March 31, 2020 08:55
@snyk-bot snyk-bot mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@childish-sambino childish-sambino childish-sambino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shrujalshah28 @childish-sambino @thinkingserious