Skip to content

fix: correct the attachment file path test #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
childish-sambino merged 3 commits into from
Mar 30, 2020
Merged

fix: correct the attachment file path test #852

childish-sambino merged 3 commits into from
Mar 30, 2020

Conversation

@digitalica
Copy link
Contributor

@digitalica digitalica commented Dec 2, 2018

Short description of what this PR does:

  • replaces babel-preset-es2015 (deprecated) by babel-preset-env
  • add testing voor nodejs 10

Checklist

  • [x ] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [x ] I have read the [Contribution Guide] and my PR follows them.
  • [x ] I updated my branch with the master branch.
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] I have added necessary documentation about the functionality in the appropriate .md file
  • [x ] I have added inline documentation to the code I modified

@digitalica
move from babal-preset-es2015 to babel-preset-env
8b71ae1 
as documented: https://babeljs.io/docs/en/env/

prevents lots of npm audit warnings:

found 394 vulnerabilities (382 low, 6 moderate, 5 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

to

found 251 vulnerabilities (239 low, 6 moderate, 5 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details
@digitalica
fix tests
fb59653
@digitalica
also run tests in node 10
61d53f8
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 2, 2018
@SendGridDX
Copy link

SendGridDX commented Dec 2, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@childish-sambino childish-sambino force-pushed the master branch 5 times, most recently from 389fa8c to 37473ad Compare January 15, 2020 21:44
@childish-sambino childish-sambino changed the title replace babel-preset-es2015 (deprecated) by babel-preset-env fix: correct the attachment file path test Mar 30, 2020
@childish-sambino childish-sambino merged commit dba7f7b into sendgrid:master Mar 30, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@childish-sambino childish-sambino childish-sambino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@digitalica @SendGridDX @childish-sambino @thinkingserious