Skip to content

Conversation

@eshanholtz
Copy link
Contributor

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 12, 2020
@eshanholtz eshanholtz changed the title chore: upgrade dev dependencies and fix eslint warnings/errors chore!: upgrade dev dependencies and fix eslint warnings/errors Mar 13, 2020
@eshanholtz eshanholtz changed the title chore!: upgrade dev dependencies and fix eslint warnings/errors [DO NOT MERGE] chore!: upgrade dev dependencies and fix eslint warnings/errors Mar 18, 2020
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can drop the ! since it's no longer breaking!

@eshanholtz eshanholtz changed the title [DO NOT MERGE] chore!: upgrade dev dependencies and fix eslint warnings/errors [DO NOT MERGE] chore: upgrade dev dependencies and fix eslint warnings/errors Mar 19, 2020
@eshanholtz eshanholtz changed the title [DO NOT MERGE] chore: upgrade dev dependencies and fix eslint warnings/errors chore!: upgrade dev dependencies and fix eslint warnings/errors Mar 19, 2020
@eshanholtz eshanholtz merged commit 8075616 into master Mar 19, 2020
@eshanholtz eshanholtz deleted the dev-upgrade branch March 19, 2020 18:12
@eshanholtz eshanholtz changed the title chore!: upgrade dev dependencies and fix eslint warnings/errors chore: upgrade dev dependencies and fix eslint warnings/errors Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants