Skip to content

feat!: migrate from deprecated request module to axios #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thinkingserious merged 23 commits into from
Mar 24, 2020
Merged

feat!: migrate from deprecated request module to axios #1058

thinkingserious merged 23 commits into from
Mar 24, 2020

Conversation

@eshanholtz
Copy link
Contributor

@eshanholtz eshanholtz commented Mar 9, 2020 •
edited by childish-sambino
Loading

Fixes #1042

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 9, 2020
@eshanholtz
Copy link
Contributor Author

eshanholtz commented Mar 9, 2020 •
edited
Loading

Upgrading eslint (security remediation) requires node != 7

childish-sambino
childish-sambino reviewed Mar 10, 2020
View reviewed changes
childish-sambino
childish-sambino reviewed Mar 12, 2020
View reviewed changes
@eshanholtz eshanholtz changed the title feat: migrate from deprecated request module to axios [DO NOT MERGE] feat: migrate from deprecated request module to axios Mar 12, 2020
childish-sambino
childish-sambino reviewed Mar 16, 2020
View reviewed changes
childish-sambino
childish-sambino reviewed Mar 17, 2020
View reviewed changes
childish-sambino
childish-sambino reviewed Mar 19, 2020
View reviewed changes
childish-sambino
childish-sambino reviewed Mar 19, 2020
View reviewed changes
childish-sambino
childish-sambino approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Needs to be marked as breaking !. But don't merge yet.

@eshanholtz eshanholtz changed the title [DO NOT MERGE] feat: migrate from deprecated request module to axios [DO NOT MERGE] feat!: migrate from deprecated request module to axios Mar 19, 2020
@thinkingserious thinkingserious changed the title [DO NOT MERGE] feat!: migrate from deprecated request module to axios feat!: migrate from deprecated request module to axios Mar 24, 2020
@thinkingserious thinkingserious merged commit b2b40de into master Mar 24, 2020
@thinkingserious thinkingserious deleted the request-to-axios branch March 24, 2020 22:17
@jandppw
Copy link

jandppw commented Apr 5, 2020

Can somebody specify why this is breaking? (So we can check whether it has impact on our usage code). I can't see that from browsing the code changes.

@childish-sambino
Copy link
Contributor

childish-sambino commented Apr 6, 2020

@jandppw https://github.com/sendgrid/sendgrid-nodejs/blob/master/docs/migration-guides/migrating-from-version-6-to-7.md

@snyk-bot snyk-bot mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@childish-sambino childish-sambino childish-sambino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

warning > request@2.88.2 deprecated

4 participants

@eshanholtz @jandppw @childish-sambino @thinkingserious