Skip to content

remove duplicate call of term.GetSize#156

Merged
schollz merged 1 commit intoschollz:mainfrom
talwat:termwidth-fix
Mar 14, 2023
Merged

remove duplicate call of term.GetSize#156
schollz merged 1 commit intoschollz:mainfrom
talwat:termwidth-fix

Conversation

@talwat
Copy link
Copy Markdown
Contributor

@talwat talwat commented Feb 28, 2023

No description provided.

@schollz
Copy link
Copy Markdown
Owner

schollz commented Mar 14, 2023

Thanks!

@schollz schollz merged commit d5980c4 into schollz:main Mar 14, 2023
kodiakhq bot referenced this pull request in cloudquery/plugin-sdk Apr 1, 2023
…#750)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/schollz/progressbar/v3](https://togithub.com/schollz/progressbar) | require | patch | `v3.13.0` -> `v3.13.1` |

---

### Release Notes

<details>
<summary>schollz/progressbar</summary>

### [`v3.13.1`](https://togithub.com/schollz/progressbar/releases/tag/v3.13.1)

[Compare Source](https://togithub.com/schollz/progressbar/compare/v3.13.0...v3.13.1)

#### What's Changed

-   fix: remove github.com/rivo/uniseg from go.mod to fix go version by [@&#8203;DarthPestilane](https://togithub.com/DarthPestilane) in [https://github.com/schollz/progressbar/pull/158](https://togithub.com/schollz/progressbar/pull/158)
-   remove duplicate call of term.GetSize by [@&#8203;talwat](https://togithub.com/talwat) in [https://github.com/schollz/progressbar/pull/156](https://togithub.com/schollz/progressbar/pull/156)
-   fix data race in `Describe` by [@&#8203;kemingy](https://togithub.com/kemingy) in [https://github.com/schollz/progressbar/pull/153](https://togithub.com/schollz/progressbar/pull/153)

#### New Contributors

-   [@&#8203;DarthPestilane](https://togithub.com/DarthPestilane) made their first contribution in [https://github.com/schollz/progressbar/pull/158](https://togithub.com/schollz/progressbar/pull/158)
-   [@&#8203;talwat](https://togithub.com/talwat) made their first contribution in [https://github.com/schollz/progressbar/pull/156](https://togithub.com/schollz/progressbar/pull/156)
-   [@&#8203;kemingy](https://togithub.com/kemingy) made their first contribution in [https://github.com/schollz/progressbar/pull/153](https://togithub.com/schollz/progressbar/pull/153)

**Full Changelog**: schollz/progressbar@v3.13.0...v3.13.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTkuMiIsInVwZGF0ZWRJblZlciI6IjM0LjE1OS4yIn0=-->
WGH- added a commit to WGH-/progressbar that referenced this pull request Feb 7, 2025
Instead of always checking stdout, check the actually configured output
file. Fixes cases when stdout is redirected to a file or /dev/null, but
stderr remains connected to the terminal.

It was previously fixed in schollz#91, but was broken in schollz#156.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants