fix issue 20901: etaCollapse context bound type#20910
Merged
sjrd merged 2 commits intoscala:mainfrom Jul 1, 2024
Merged
Conversation
hamzaremmal
reviewed
Jul 3, 2024
Member
There was a problem hiding this comment.
It looks like this test is breaking the Scala 2 Library TASTy test in the latest nightly: https://github.com/scala/scala3/actions/runs/9771174027/job/26973528590
Member
Author
There was a problem hiding this comment.
The failure is in the TASTy output test added in this PR, but the difference doesn't seem related to context bounds - tree 68 changed - the inferred result type
-68: SHAREDtype 44
+68: TYPEREF 17 [Nothing]
+70: TERMREFpkg 2 [scala]
Member
Author
There was a problem hiding this comment.
I guess we could possibly update the test to remove inference, or just stop the tasty checking
Member
Author
There was a problem hiding this comment.
or test with decompilation rather than printing tasty?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #20901