Merged
Conversation
ccoVeille
approved these changes
Jul 15, 2024
| last = len(collection) | ||
| } | ||
| result = append(result, collection[i*size:last]) | ||
| result = append(result, collection[i*size:last:last]) |
Contributor
There was a problem hiding this comment.
I had never faced this notation, with the capacity apparently
Contributor
Author
There was a problem hiding this comment.
Comment on lines
+239
to
+243
| // appending to a chunk should not affect original array | ||
| originalArray := []int{0, 1, 2, 3, 4, 5} | ||
| result5 := Chunk(originalArray, 2) | ||
| result5[0] = append(result5[0], 6) | ||
| is.Equal(originalArray, []int{0, 1, 2, 3, 4, 5}) |
Contributor
There was a problem hiding this comment.
So. it's not only a fix of a possible memory leak, but also a functional fix, no?
I'm unsure why you are adding this check.no computer with me to check.
My point is that the commit message could mention a memory leak fix + bug fix, maybe
Contributor
Author
There was a problem hiding this comment.
yeah, updated the title
Owner
|
I would recommend using It consumes more memory, but it seems safer to me. |
Contributor
Author
using copy will be slower compared to current implementation: Benchmark without using copy: |
Owner
|
I will discuss it in another issue. |
github-actions bot
referenced
this pull request
in kairos-io/provider-kairos
Jul 15, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.45.0` -> `v1.46.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.46.0`](https://togithub.com/samber/lo/releases/tag/v1.46.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.45.0...v1.46.0) #### What's Changed - fix: chunk memory leak, bug fix by [@​mihir20](https://togithub.com/mihir20) in [https://github.com/samber/lo/pull/491](https://togithub.com/samber/lo/pull/491) - feat: add WaitForWithContext by [@​ccoVeille](https://togithub.com/ccoVeille) in [https://github.com/samber/lo/pull/480](https://togithub.com/samber/lo/pull/480) - add ForEachCondition implement by [@​Sianao](https://togithub.com/Sianao) in [https://github.com/samber/lo/pull/485](https://togithub.com/samber/lo/pull/485) #### New Contributors - [@​mihir20](https://togithub.com/mihir20) made their first contribution in [https://github.com/samber/lo/pull/491](https://togithub.com/samber/lo/pull/491) - [@​ccoVeille](https://togithub.com/ccoVeille) made their first contribution in [https://github.com/samber/lo/pull/480](https://togithub.com/samber/lo/pull/480) - [@​Sianao](https://togithub.com/Sianao) made their first contribution in [https://github.com/samber/lo/pull/485](https://togithub.com/samber/lo/pull/485) **Full Changelog**: samber/lo@v1.45.0...v1.46.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Jul 17, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/samber/lo](https://togithub.com/samber/lo) | `v1.44.0` -> `v1.46.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>samber/lo (github.com/samber/lo)</summary> ### [`v1.46.0`](https://togithub.com/samber/lo/releases/tag/v1.46.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.45.0...v1.46.0) #### What's Changed - fix: chunk memory leak, bug fix by [@​mihir20](https://togithub.com/mihir20) in [https://github.com/samber/lo/pull/491](https://togithub.com/samber/lo/pull/491) - feat: add WaitForWithContext by [@​ccoVeille](https://togithub.com/ccoVeille) in [https://github.com/samber/lo/pull/480](https://togithub.com/samber/lo/pull/480) - add ForEachCondition implement by [@​Sianao](https://togithub.com/Sianao) in [https://github.com/samber/lo/pull/485](https://togithub.com/samber/lo/pull/485) #### New Contributors - [@​mihir20](https://togithub.com/mihir20) made their first contribution in [https://github.com/samber/lo/pull/491](https://togithub.com/samber/lo/pull/491) - [@​ccoVeille](https://togithub.com/ccoVeille) made their first contribution in [https://github.com/samber/lo/pull/480](https://togithub.com/samber/lo/pull/480) - [@​Sianao](https://togithub.com/Sianao) made their first contribution in [https://github.com/samber/lo/pull/485](https://togithub.com/samber/lo/pull/485) **Full Changelog**: samber/lo@v1.45.0...v1.46.0 ### [`v1.45.0`](https://togithub.com/samber/lo/releases/tag/v1.45.0) [Compare Source](https://togithub.com/samber/lo/compare/v1.44.0...v1.45.0) #### What's Changed - perf: preallocate in Assign by [@​pmalek](https://togithub.com/pmalek) in [https://github.com/samber/lo/pull/484](https://togithub.com/samber/lo/pull/484) - feat: adding EarliestBy and LatestBy functions by [@​timych](https://togithub.com/timych) in [https://github.com/samber/lo/pull/489](https://togithub.com/samber/lo/pull/489) #### New Contributors - [@​pmalek](https://togithub.com/pmalek) made their first contribution in [https://github.com/samber/lo/pull/484](https://togithub.com/samber/lo/pull/484) - [@​timych](https://togithub.com/timych) made their first contribution in [https://github.com/samber/lo/pull/489](https://togithub.com/samber/lo/pull/489) **Full Changelog**: samber/lo@v1.44.0...v1.45.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raising a fix as mentioned in: #438