Feat: Add vibrate field to NotificationOptions in web-sys crate#4041
Merged
daxpedda merged 2 commits intowasm-bindgen:mainfrom Aug 3, 2024
Merged
Feat: Add vibrate field to NotificationOptions in web-sys crate#4041daxpedda merged 2 commits intowasm-bindgen:mainfrom
vibrate field to NotificationOptions in web-sys crate#4041daxpedda merged 2 commits intowasm-bindgen:mainfrom
Conversation
- Updated `Notification.webidl` to include the `vibrate` field in the `NotificationOptions` dictionary. - Added getter `get_vibrate` to retrieve the `vibrate` field of `NotificationOptions`. - Added setter `set_vibrate` to change the `vibrate` field of `NotificationOptions`.
daxpedda
approved these changes
Aug 3, 2024
Member
daxpedda
left a comment
There was a problem hiding this comment.
Thank you!
I added a changelog entry and corrected the type to follow the specification.
Unfortunately we don't handle unions very well right now, so that's the best we have until the next breaking change of web-sys.
Contributor
Author
|
Sounds good. Thanks for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification.webidlto include thevibratefield in theNotificationOptionsdictionary.get_vibrateto retrieve thevibratefield ofNotificationOptions.set_vibrateto change thevibratefield ofNotificationOptions.