Add .into() to the generated code for async fns#3919
Merged
daxpedda merged 2 commits intowasm-bindgen:mainfrom Jul 28, 2024
Merged
Add .into() to the generated code for async fns#3919daxpedda merged 2 commits intowasm-bindgen:mainfrom
.into() to the generated code for async fns#3919daxpedda merged 2 commits intowasm-bindgen:mainfrom
Conversation
.into() to the generated code for async fns
This was referenced Apr 10, 2024
daxpedda
approved these changes
Jul 28, 2024
Member
daxpedda
left a comment
There was a problem hiding this comment.
I'm surprised this hasn't come up until now.
This was referenced Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this I am getting an error for declarations like these:
I have tried to also create a test for this to catch regressions, but was unable to figure out where to put it.
Test