Make catch thread safe#3879
Merged
daxpedda merged 1 commit intowasm-bindgen:mainfrom Mar 10, 2024
Merged
Conversation
Liamolucko
approved these changes
Mar 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some significant amount of time debugging corrupted memory, I found the culprit of some random crashes I had: a
static mutwas used to implementcatch, which obviously introduces a race condition if mutated and accessed from multiple threads at the same time.My assumption here is that this was done to preserve no-std, which has been broken a long time ago. I also double-checked all other
statics, but didn't find any other culprits.