fix missing typeof operator in __wbg_init() template in no-modules#3748
Merged
daxpedda merged 3 commits intowasm-bindgen:mainfrom Dec 20, 2023
Merged
fix missing typeof operator in __wbg_init() template in no-modules#3748daxpedda merged 3 commits intowasm-bindgen:mainfrom
daxpedda merged 3 commits intowasm-bindgen:mainfrom
Conversation
daxpedda
requested changes
Dec 20, 2023
Member
daxpedda
left a comment
There was a problem hiding this comment.
I think we have messed this up before, not sure what happened here.
Thank you!
Could you add a note in the changelog?
daxpedda
reviewed
Dec 20, 2023
Contributor
Author
|
Cheers 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a TypeError originating in the generated javascript wrapper when using the
--no-modulesflag (I was messing around with web workers which can result inscript_srcactually being undefined).It appears the check is for
undefinedis against the value ofstring_src, rather than the type.