Update docs to say that wasm_bindgen::module() is also available with --target web.#3690
Merged
daxpedda merged 2 commits intowasm-bindgen:mainfrom Nov 10, 2023
Merged
Conversation
wasm_bindgen::module() is also available with --target-web.wasm_bindgen::module() is also available with --target web.
daxpedda
reviewed
Nov 9, 2023
Member
daxpedda
left a comment
There was a problem hiding this comment.
I'm fine with moving this to stable, what it exposes is stable after all. WebAssembly.Memory, ``WebAssembly.TableandWebAssembly.Instance.prototype.exports` is already stably exported as well.
Could you go ahead and do that as well in this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs were originally written in this commit with a corresponding runtime check. The runtime check was updated here* , but the corresponding doc was not updated. This PR updates that doc.
Separately, what would it take to graduate this API to a non-experiment?