Return an error if there are two enums with the same name#3669
Merged
daxpedda merged 2 commits intowasm-bindgen:mainfrom Oct 26, 2023
Merged
Return an error if there are two enums with the same name#3669daxpedda merged 2 commits intowasm-bindgen:mainfrom
daxpedda merged 2 commits intowasm-bindgen:mainfrom
Conversation
daxpedda
requested changes
Oct 25, 2023
Member
daxpedda
left a comment
There was a problem hiding this comment.
LGTM!
Could you add a note in the changelog as well?
…rwriting the first one.
3f5fd0a to
0259a5c
Compare
Contributor
Author
|
Thanks for the quick review, added a note in the changelog under |
daxpedda
reviewed
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue that two enums with the same name cause the "second" one to overwrite the "first" one.
Currently, looking at the output of
target/wasm32-unknown-unknown/wbg-tmp-wasm-<some-hex-characters>.wasm/wasm-bindgen-test.jsgenerated withthe part with the enums (was at line 4849 for me) looks like this:
The second assignment
module.exports.Color =overwrites the first one, causing the first one to have no effect.The reason this was not captured by the tests is that the two enums were identical in shape (same unit keys/values).