Unwrap argument types in macro#3625
Merged
daxpedda merged 7 commits intowasm-bindgen:mainfrom Sep 20, 2023
Merged
Conversation
`syn` wraps argument types in a `syn::TypeGroup` for free functions/methods generated from `macro_rules!` this means that references end up generating wrong code during proc macro expansion. This PR unwraps argument types in `syn::TypeGroup` and matches against the inner element for such cases. Fixes wasm-bindgen#3078 Signed-off-by: Oliver T <geronimooliver00@gmail.com>
Signed-off-by: Oliver T <geronimooliver00@gmail.com>
Liamolucko
reviewed
Sep 20, 2023
Signed-off-by: Oliver T <geronimooliver00@gmail.com>
daxpedda
requested changes
Sep 20, 2023
Member
daxpedda
left a comment
There was a problem hiding this comment.
Could you add a test for this?
Signed-off-by: Oliver T <geronimooliver00@gmail.com>
daxpedda
reviewed
Sep 20, 2023
Signed-off-by: Oliver T <geronimooliver00@gmail.com>
Signed-off-by: Oliver T <geronimooliver00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
synwraps argument types in asyn::TypeGroupfor free functions/methods generated frommacro_rules!this means that references end up generating wrong code during proc macro expansion.This PR unwraps argument types in
syn::TypeGroupand matches against the inner element for such cases.Fixes #3078