Add missing implementations of core iterator traits#734
Merged
BurntSushi merged 1 commit intorust-lang:masterfrom Dec 29, 2020
lopopolo:missing-iterator-impls
Merged
Add missing implementations of core iterator traits#734BurntSushi merged 1 commit intorust-lang:masterfrom lopopolo:missing-iterator-impls
BurntSushi merged 1 commit intorust-lang:masterfrom
lopopolo:missing-iterator-impls
Conversation
BurntSushi
requested changes
Dec 29, 2020
Member
BurntSushi
left a comment
There was a problem hiding this comment.
LGTM! I think there are a couple of impls we don't need though?
- Add missing implementations of FusedIterator. - Add missing implementations of ExactSizeIterator. - Add missing overrides of `Iterator::count` when wrapping a slice iterator. - Add missing overrides of `Iterator::size_hint` when size hint is known.
Contributor
Author
|
@BurntSushi I've removed the impls on internal types you flagged. |
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
This was referenced Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iterator::countwhen wrapping a slice iterator.Iterator::size_hintwhen size hint is known.Context: I'm building an implementation of Ruby
Regexpon top of theregexcrate, and having guarantees around whether iterators are fused will allow me to implement these traits on my wrappingIterators as well.