Merged
Conversation
Merged
3af90a5 to
e8b4d8b
Compare
0724e1a to
dbf85ff
Compare
Contributor
Author
|
so the API is done, but I am a little lost as to why the test does not work, even though I specify a pathspec, both file changes are gone after the stash 🤯 |
try getting tests to work again fix tests cleanup safe api fix unittest
9c3d67d to
672a0f3
Compare
Contributor
Author
|
this PR is ready for merge @ehuss |
ehuss
reviewed
May 5, 2023
Co-authored-by: Eric Huss <eric@huss.org>
Contributor
Author
|
@ehuss I addressed your feedback |
Contributor
Author
|
@ehuss thanks for merging can you cut a release please? :) |
Contributor
|
Sure! It should be published now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in Progress.
Need some help here: I guess updating the submodule breaks a lot of things. I did not dive into their release pipeline but it seems releases are cherry picked. I will wait for another release that contains the new feature
closes #929