Skip to content

fix: strip BOM before calling transform hook#5268

Merged
lukastaegert merged 1 commit intomasterfrom
fix/xiaopi-bom
Nov 24, 2023
Merged

fix: strip BOM before calling transform hook#5268
lukastaegert merged 1 commit intomasterfrom
fix/xiaopi-bom

Conversation

@TrickyPi
Copy link
Copy Markdown
Member

@TrickyPi TrickyPi commented Nov 23, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5258

Description

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 0:07am

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 23, 2023 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/xiaopi-bom

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-959tpz9t0-rollup-js.vercel.app/repl/?pr=5268

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a083019) 98.87% compared to head (e8dc65c) 98.87%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5268   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         232      232           
  Lines        8945     8946    +1     
  Branches     2334     2334           
=======================================
+ Hits         8844     8845    +1     
  Misses         42       42           
  Partials       59       59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lukastaegert
lukastaegert approved these changes Nov 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@lukastaegert lukastaegert added this pull request to the merge queue Nov 24, 2023
Merged via the queue into master with commit 08da9ee Nov 24, 2023
@lukastaegert lukastaegert deleted the fix/xiaopi-bom branch November 24, 2023 05:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 24, 2023

This PR has been released as part of rollup@4.5.2. You can test it via npm install rollup.

@github-actions github-actions Bot mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[commonjs-resolver] can not parse umd file properly (possibly)due to BOM marker

2 participants

@TrickyPi @lukastaegert