fix: config path problem on windows#4501
Merged
lukastaegert merged 2 commits intorollup:masterfrom May 19, 2022
Merged
Conversation
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #4501 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 207 207
Lines 7342 7342
Branches 2081 2081
=======================================
Hits 7250 7250
Misses 33 33
Partials 59 59
Continue to review full report at Codecov.
|
lukastaegert
approved these changes
May 19, 2022
Member
lukastaegert
left a comment
There was a problem hiding this comment.
Great work, thank you so much! The solution is perfect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #3949
#4260
#4439
#4440
#4446
resolves #4465
Description
The
loadConfigFromBundledFilefunction patches the defaultrequirealgorithm for thefileNamefile. It replaces the require.extensions handler for it. In certain scenarios the file name parameter value in therequire.extensionshandler differs from the required file name (for example for symlinked files). The #3783 fix processed this by preparing the input file name before comparation. It uses the fsPromises.realpath function for it. The problem is that thefsPromises.realpathresult and the file name in therequire.extensionshandler are not the same in certain scenarios (refer to the relevant issue list above). I suggest use the require.resolve function instead of thefsPromises.realpathbecause therequireand therequire.resolvefunctions use the same algorithm.