Skip to content

chore: use forceConsistentCasingInFileNames in ts-config#4220

Merged
lukastaegert merged 2 commits intorollup:masterfrom
dnalborczyk:dn/ts-config-casing
Sep 6, 2021
Merged

chore: use forceConsistentCasingInFileNames in ts-config#4220
lukastaegert merged 2 commits intorollup:masterfrom
dnalborczyk:dn/ts-config-casing

Conversation

@dnalborczyk
Copy link
Copy Markdown
Contributor

@dnalborczyk dnalborczyk commented Sep 3, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

just for good house keeping. recommended setting.

https://www.typescriptlang.org/tsconfig/#forceConsistentCasingInFileNames

TypeScript follows the case sensitivity rules of the file system it’s running on. This can be problematic if some developers are working in a case-sensitive file system and others aren’t. If a file attempts to import fileManager.ts by specifying ./FileManager.ts the file will be found in a case-insensitive file system, but not on a case-sensitive file system.

When this option is set, TypeScript will issue an error if a program tries to include a file by a casing different from the casing on disk.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 3, 2021 •
edited
Loading

Codecov Report

Merging #4220 (17fa209) into master (81fa9e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4220   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         202      202           
  Lines        7259     7259           
  Branches     2119     2119           
=======================================
  Hits         7141     7141           
  Misses         58       58           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81fa9e9...17fa209. Read the comment docs.

lukastaegert
lukastaegert approved these changes Sep 6, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukastaegert lukastaegert merged commit 181f379 into rollup:master Sep 6, 2021
@dnalborczyk dnalborczyk deleted the dn/ts-config-casing branch September 7, 2021 01:43
@sync-by-unito sync-by-unito Bot mentioned this pull request Sep 22, 2021
Closed
@sync-by-unito sync-by-unito Bot mentioned this pull request Oct 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnalborczyk @lukastaegert