Align batch warning for UNUSED_EXTERNAL_IMPORT to individual warning#4194
Merged
lukastaegert merged 7 commits intorollup:masterfrom Jul 29, 2021
Merged
Align batch warning for UNUSED_EXTERNAL_IMPORT to individual warning#4194lukastaegert merged 7 commits intorollup:masterfrom
lukastaegert merged 7 commits intorollup:masterfrom
Conversation
73c1f92 to
edbb2c8
Compare
edbb2c8 to
a2d27ed
Compare
Codecov Report
@@ Coverage Diff @@
## master #4194 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 202 202
Lines 7243 7244 +1
Branches 2123 2123
=======================================
+ Hits 7123 7124 +1
Misses 58 58
Partials 62 62
Continue to review full report at Codecov.
|
Member
lukastaegert
left a comment
There was a problem hiding this comment.
A nice addition, just a small potential cleanup (that should also fix coverage).
| stderr, | ||
| '(!) Unused external imports\n' + | ||
| "default imported from external module 'external' but never used\n" | ||
| `default imported from external module 'external' but never used in "main.js"\n` |
Member
There was a problem hiding this comment.
While you are at it, maybe we could align on using double quotes " also for the module name. This is also what most other errors use.
Open
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
The original issue which was closed is #4052. This finishes addressing that issue
Description
PR #4054 improved the individual warning, but did not update the batch warning. When I build SvelteKit with Vite, which uses Rollup, I get a warning that I can't understand the origin of or how to fix
After using a locally modified copy, I was quickly able to track down the culprit: ampproject/amphtml#35435