Deoptimize awaited expressions#4162
Merged
lukastaegert merged 1 commit intomasterfrom Jul 1, 2021
Merged
Conversation
55b60aa to
c9f63de
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4161-await-dropping-codeor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4162 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 201 201
Lines 7127 7130 +3
Branches 2088 2089 +1
=======================================
+ Hits 7005 7008 +3
Misses 58 58
Partials 64 64
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4161
Description
Currently, we are not tracking object deoptimizations through await expressions. This PR simplifies the logic here by always deoptimizing await expressions to avoid the complicated promise logic