Properly handle double reexports from external namespaces#4159
Merged
lukastaegert merged 1 commit intomasterfrom Jun 30, 2021
Merged
Properly handle double reexports from external namespaces#4159lukastaegert merged 1 commit intomasterfrom
lukastaegert merged 1 commit intomasterfrom
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4158-double-reexportor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4159 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 201 201
Lines 7118 7125 +7
Branches 2084 2087 +3
=======================================
+ Hits 6996 7003 +7
Misses 58 58
Partials 64 64
Continue to review full report at Codecov.
|
guybedford
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4158
Description
This fixes an issue with the new logic that prefers local namespace reexports over external ones. Basically what was happening that the logic to detect cycles was preventing proper resolution of external namespace reexports if the reexports went over several steps.