Drop unused last sequence element#4087
Merged
lukastaegert merged 8 commits intomasterfrom May 25, 2021
Merged
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4083-unused-last-sequence-elementor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4087 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 201 201
Lines 6987 6992 +5
Branches 2051 2053 +2
=======================================
+ Hits 6848 6853 +5
Misses 66 66
Partials 73 73
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4083
Description
This will remove the last element in a sequence (comma) expression if the parent is an expression statement and it has no side effects. This is the most simple approach as it will not handle situations where e.g. the expression is nested in a conditional.
A more fully featured way of doing it could be.g. to introduce a flag to the
includemethod to control if the value is needed. Such an extension could also be used to e.g. drop unused return expressions in functions if the return value is unused in all call expressions.